New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/2.7 backport] Add reference.ParseDockerRef utility function #3002
[release/2.7 backport] Add reference.ParseDockerRef utility function #3002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thaJeztah! LGTM.
ping @dmcgowan PTAL |
ParseDockerRef normalizes the image reference following the docker convention. This is added mainly for backward compatibility. The reference returned can only be either tagged or digested. For reference contains both tag and digest, the function returns digested reference, e.g. docker.io/library/busybox:latest@sha256:7cc4b5aefd1d0cadf8d97d4350462ba51c694ebca145b08d7d41b41acc8db5aa will be returned as docker.io/library/busybox@sha256:7cc4b5aefd1d0cadf8d97d4350462ba51c694ebca145b08d7d41b41acc8db5aa. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 0ac367f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ad4fa05
to
fad36ed
Compare
rebased to make the vendor-check pass (which should be fixed by #3001) |
Codecov Report
@@ Coverage Diff @@
## release/2.7 #3002 +/- ##
===============================================
+ Coverage 60.25% 60.38% +0.13%
===============================================
Files 103 103
Lines 8024 8038 +14
===============================================
+ Hits 4835 4854 +19
+ Misses 2546 2537 -9
- Partials 643 647 +4
Continue to review full report at Codecov.
|
ping @dmcgowan @manishtomar @stevvooe PTAL |
LGTM |
backport of #2786 for the release/2.7 branch
to address containerd/containerd#3031 if included in a 2.7.x patch release
ParseDockerRef normalizes the image reference following the docker
convention. This is added mainly for backward compatibility. The reference
returned can only be either tagged or digested. For reference contains both tag
and digest, the function returns digested reference, e.g.
will be returned as